Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-26024] Display a more informative error message #39

Merged
merged 1 commit into from
Sep 29, 2017
Merged

[JENKINS-26024] Display a more informative error message #39

merged 1 commit into from
Sep 29, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented May 24, 2016

Amends #31 to indicate which subclass needs to be updated. I found the following stack trace in a log file:

java.lang.AbstractMethodError: you must override the new overload of isApplicable
        at com.sonyericsson.rebuild.RebuildValidator.isApplicable(RebuildValidator.java:50)
        at com.sonyericsson.rebuild.RebuildActionFactory.createFor(RebuildActionFactory.java:61)
        at hudson.model.Run.getTransientActions(Run.java:373)

but the installation does not seem to include gerrit-trigger, which is the only public implementor I can find (and which is fixed as of jenkinsci/gerrit-trigger-plugin#240).

@reviewbybees

@ghost
Copy link

ghost commented Jun 16, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev
Copy link
Member

🐝

@jglick
Copy link
Member Author

jglick commented Jun 16, 2016

@reviewbybees done

Up for review by @hagzag or @rsandell.

@rsandell
Copy link
Member

👍

@jglick
Copy link
Member Author

jglick commented Feb 2, 2017

So @rsandell are you maintaining this plugin, or is someone else?

@jglick jglick requested a review from GLundh September 29, 2017 17:47
@GLundh
Copy link
Member

GLundh commented Sep 29, 2017

LGTM. I've talked to the owner Ragesh Nair and he has OKed that I release a new version, which I plan to do soon,

@GLundh GLundh merged commit bf41e54 into jenkinsci:master Sep 29, 2017
@jglick jglick deleted the diag-JENKINS-26024 branch October 11, 2017 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GLundh GLundh GLundh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jglick @oleg-nenashev @rsandell @GLundh